feat: add pr diff support via /raw proxy route#6
Merged
Conversation
chaodu-agent
force-pushed
the
feat/pr-diff
branch
3 times, most recently
from
575b6ae to
be108c9
Compare
- ghp: route 'pr diff' through ghpool /raw/ endpoint
- ghp: route 'pr checks' through ghpool (fetches PR head SHA, then check-runs)
- ghpool: add /raw/{*path} handler for non-JSON responses (diffs, patches)
- ghpool: share single reqwest::Client via AppState (all handlers)
- Add 12 ghp unit tests + 5 ghpool integration tests
chaodu-agent
force-pushed
the
feat/pr-diff
branch
from
be108c9 to
cf22897
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
gh pr diffsupport to the ghp shim by introducing a/raw/{*path}route on ghpool.Changes
pr diff <number> -R <repo>through ghpool's new/raw/endpoint withAccept: application/vnd.github.v3.diffheader/raw/{*path}handler that proxies to GitHub API and returns raw text (not JSON), supporting diff/patch content typesWhy
Previously
ghp pr difffell through to the realghbinary which requires local OAuth. With this change, bots can view PR diffs without needinggh auth login— the pooled PAT handles auth.